Skip to content

astolat
shalott

  • Joined on

Organizations

@otwcode
shalott commented on pull request otwcode/otwarchive#2288
@shalott

This all looks good to me now! stamps

shalott commented on pull request otwcode/otwarchive#2288
@shalott

Hound is right, this value of parent is never used

shalott commented on pull request otwcode/otwarchive#2295
@shalott

Hmm is it used in the tag set nominations? If it's not there then it's just outdated from when we were looking at doing more Ajaxy editing. Naomi O…

shalott commented on pull request otwcode/otwarchive#2288
@shalott

This looks good to me, I will be annoying and suggest also checking that a skin cache expires after its parent is saved and that the cache does NOT…

shalott commented on pull request otwcode/otwarchive#2288
@shalott

Just checking, is this going to work on vagrant or does the vagrant need to be updated?

shalott commented on pull request otwcode/otwarchive#2227
@shalott

But then you're adding loads of irrelevant cache key methods to whatever class you add this module to?

shalott commented on pull request otwcode/otwarchive#2227
@shalott

Also Sarken's indentation comment has not been addressed and there is still no automated test.

shalott commented on pull request otwcode/otwarchive#2227
@shalott

would rename this skin_cache_helper since cache_helper is too generic

shalott commented on pull request otwcode/otwarchive#2227
@shalott

I think you should write the tests. This is not just one line of code, this pullreq is a lot of code trying to have the effect of expiring a lot of…

shalott commented on pull request otwcode/otwarchive#2227
@shalott

I mean, Rails uses metaprogramming all over the place to make more intuitive and readable code, which is significantly more expensive than the simp…

shalott commented on pull request otwcode/otwarchive#2227
@shalott

One final comment: I think this really could use an automated test to make sure the cache is expiring when you want it to. There's a test in bookma…

@shalott
shalott commented on pull request otwcode/otwarchive#2227
@shalott

Not sure what this is here in this pullreq for?

shalott commented on pull request otwcode/otwarchive#2227
@shalott

This now looks right to me in terms of not over-expiring, but can I make a request? Can you move this line of code into a separate clearly named me…

shalott commented on pull request otwcode/otwarchive#2227
@shalott

Ditto to this--I think it's a perfectly good idea to break up the prompt memes tests (they really need a total overhaul) but doesn't seem to belong…

@shalott
  • @shalott a6d4cba
    Update _challenge_signups.html.erb
@shalott
  • @shalott 7cfaf87
    fixed per enigel's comment
@shalott
shalott commented on pull request otwcode/otwarchive#2233
@shalott

Looks good!

shalott commented on pull request otwcode/otwarchive#2229
@shalott

The issue I spotted is fixed however so once the merge fixes are done I am happy for this to be marked ready-to-merge, this looks v useful

shalott commented on pull request otwcode/otwarchive#1975
@shalott

This looks good to me but has no automated tests at all? Would suggest this feature (can help with step definitions if you need): Scenario: User's …

@shalott
  • @shalott b6f289c
    HA DEATH TO THE INTERMITTENT FAILURE AT LAST
shalott commented on pull request otwcode/otwarchive#2227
@shalott

yes, I get the key-based expiration process just fine, what I don't understand is why you're doing it this way. Why are ALL skin caches being inval…

@shalott
  • @shalott e125e7c
    Merge pull request #2226 from sarken/update_schema_structure
  • @ariana-paris 497b9ea
    Merge pull request #2231 from shalott/AO3-4330-improve_ban_destroy
  • 2 more commits »
@shalott
shalott merged pull request otwcode/otwarchive#2226
@shalott
Updated schema and structure
1 commit with 245 additions and 699 deletions
@shalott
@shalott
  • @shalott df4f9f2
    a little more tweaking for the bookmark cache expiration test
@shalott
  • @shalott c649f6b
    Disabling caching on the problematic test
Something went wrong with that request. Please try again.