Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not find the source map file when use UglifyJsPlugin #81

Closed
plantain-00 opened this issue Oct 17, 2015 · 8 comments
Closed

can not find the source map file when use UglifyJsPlugin #81

plantain-00 opened this issue Oct 17, 2015 · 8 comments

Comments

@plantain-00
Copy link

@plantain-00 plantain-00 commented Oct 17, 2015

gulp.task('test', function() {
    gulp.src('frontends/scripts/index.js')
        .pipe(webpack({
            plugins: [
                new webpack.webpack.optimize.UglifyJsPlugin({ minimize: true, sourceMap: true })
            ]
        }))
        .pipe(rename("index.min.js"))
        .pipe(gulp.dest('frontends/build/scripts/'));
});

The index.min.js is created and minified properly, but I can not find any source map file.
And there is no //# sourceMappingURL=index.min.map at the end of index.min.js file.
Considering UglifyJsPlugin does have sourceMap option, is this a bug of webpack-stream?

@shama
Copy link
Owner

@shama shama commented Oct 17, 2015

webpack will output multiple destination files. Are you sure .pipe(rename("index.min.js")) isn't just renaming both of the output files to index.min.js by mistake?

@plantain-00
Copy link
Author

@plantain-00 plantain-00 commented Oct 17, 2015

@shama rename does not change this situation:

gulp.task('test', function() {
    gulp.src('frontends/scripts/index.js')
        .pipe(webpack({
            plugins: [
                new webpack.webpack.optimize.UglifyJsPlugin({ minimize: true, sourceMap: true })
            ]
        }))
        //.pipe(rename("index.min.js"))
        .pipe(gulp.dest('frontends/build/scripts/'));
});

There is only one file named 10fedf2665417c01a8c3.js, minified properly, no source map file, no //# sourceMappingURL=XXXX.map in 10fedf2665417c01a8c3.js.

@shama
Copy link
Owner

@shama shama commented Oct 17, 2015

@plantain-00 Try using webpack's source map setting instead:

.pipe(webpack({
  plugins: [
    new webpack.webpack.optimize.UglifyJsPlugin({ minimize: true })
  ],
  devtool: 'source-map'
}))

Here are docs on more options with webpack's devtool: https://webpack.github.io/docs/configuration.html#devtool

@plantain-00
Copy link
Author

@plantain-00 plantain-00 commented Oct 17, 2015

@shama it works, thanks.

@bennyn
Copy link

@bennyn bennyn commented Aug 30, 2016

Using webpack 2.1.0-beta.21, I needed to set sourceMap: true on webpack.optimize.UglifyJsPlugin AND devtool: 'source-map'.

So in the end my configuration looked like this:

webpack.config.js

var webpack = require('webpack');

module.exports = {
  devtool: 'source-map',
  entry: {
    filename: './build/proteus.js'
  },
  output: {
    filename: 'proteus-bundle.js',
    library: 'proteus',
    libraryTarget: 'amd',
    path: './dist'
  },
  node: {
    fs: 'empty',
    crypto: 'empty'
  },
  externals: {
    'libsodium-native': 'libsodium_native'
  },
  plugins: [
    new webpack.optimize.DedupePlugin(),
    new webpack.optimize.UglifyJsPlugin({
      compress: {warnings: false},
      output: {comments: false},
      sourceMap: true
    })
  ]
};
@shankie-san
Copy link

@shankie-san shankie-san commented Sep 1, 2016

Hmmm I'm having the same issue, but when using webpack straight up, rather than in Gulp. I've tried all the solutions listed here, but to no avail!

I'll report back here if I discover anything...

@alfonsoperez
Copy link

@alfonsoperez alfonsoperez commented Nov 30, 2016

sourceMaps config parameter is now false by default
https://gist.github.com/sokra/27b24881210b56bbaff7#gistcomment-1863573

@kisenka
Copy link

@kisenka kisenka commented Dec 9, 2016

It doesn't work with devtool: 'cheap-module-source-map'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.