Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabled extensions #836

Closed

Conversation

Projects
None yet
4 participants
@r-inaldi
Copy link

commented Apr 8, 2019

Short description of what this resolves:

Takes account disabled extensions when uploading or downloading the gist file.

Changes proposed in this pull request:

  • CreateExtensionList now uses code --list-extensions to get enabled and disabled extensions;
  • When download executes it verifies the extension object's enabled property . If false calls code --disable-extension with the extension name.

Fixes: #143

How Has This Been Tested?

Tested on a Macbook with VSCode.

  • Open code-settings-sync project;
  • Disable an extension;
  • While debugging (F5) inside this branch execute Upload / Update settings;
  • Then check in your gist if the current extension is disabled;
  • Leave the debugging mode and uninstall the same extension;
  • Open the debugging mode and execute Download settings;
  • Check if it installs the extension and disables it automatically.

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

knyhle and others added some commits Apr 1, 2019

Fix auto upload (#801)
* Fix auto upload!

* Properly stop watching

* Add synchronous functions

* Move watcher to a new service

* Make a new service for watcher

* Add general ignored items setting for chokidar

* Use globalCommons's autoUploadService instance

* Reset

* Add local settings to ignored files

* Asynchronously get ignored items

* Remove unused import

* Use autoUploadService

* Use the globalCommonService everywhere
Since the autoUploadService is an instance in Commons, using a global
Commons instance will allow everything to use the same instance.

* Stop spamming with extension paths

* Fix to work with async functions

* Add global state to ignored files

* Add .DS_Store and sync.lock

* Start watcher only after downloading has finished

* Inform user that auto upload has started
#823
* Go back to webpack and fix source maps
Support disabled extensions inside CreateExtList
Execute vs code list extensions command line to get all extensions 
even the ones that are disabled. Iterate over enabled extensions and 
remove it from the disabled array.
@shanalikhan

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

Thank you for the PR.
Give me some time , a week or two.
Need to merge other code PR before reviewing and merging this.

Also please open new PR , as in this PR other commits are also included.

@r-inaldi r-inaldi changed the base branch from v3.2.9 to v3.2.8 Apr 9, 2019

@r-inaldi

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

@shanalikhan sure, will do. I'm kind confused from where I should create my branch v3.2.9? Not sure why this commits got into the PR.

@r-inaldi r-inaldi changed the base branch from v3.2.8 to v3.2.9 Apr 9, 2019

@r-inaldi

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

I think I got it now @shanalikhan , will close this one in favour of #838

@r-inaldi r-inaldi closed this Apr 9, 2019

@r-inaldi r-inaldi deleted the r-inaldi:add-support-for-disabled-extensions branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.