Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GUI - Login with GitHub #846

Closed

Conversation

Projects
None yet
4 participants
@arnohovhannisyan
Copy link
Contributor

commented Apr 16, 2019

Short description of what this resolves:

This PR allows the user to log in to GitHub using a button, and the extension will automatically generate a token with the correct scopes and find the gist id.

Changes proposed in this pull request:

  • Login to GitHub using OAuth
  • Create a GUI for Settings and Welcome page
  • Allow user to choose from a list of available gists

Fixes: #506

How Has This Been Tested?

I have tested this by logging in to GitHub and checking if the token and gist id has been saved properly.

Screenshots (if appropriate):

Landing Page
Settings Page
Gist Selection Page

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

Status:

  • Authenticate with OAuth
  • Save Token
  • GUI for Gist Selection page
  • GUI for Settings page
  • GUI for Welcome page

knyhle and others added some commits Apr 8, 2019

Make sure that autoUploadService is set before using it (#832)
* Use handler methods to check if autoUploadService exists

* Update incorrect function call

* Use await before calling handlers
Fix warning from webpack [vscode-fsevents] (#834)
* Switch to vscode-chokidar

* Include vscode-fsevents as an external

@arnohovhannisyan arnohovhannisyan referenced this pull request Apr 16, 2019

Merged

docs: make generating token more user-friendly #845

2 of 3 tasks complete
docs: make generating token more user-friendly (#845)
use url query string to automatically select gist and add description
@shanalikhan

This comment has been minimized.

Copy link
Owner

commented Apr 17, 2019

Thanks.
We will a detailed UI review once v3.2.9 is released.
This PR is 3.3 worthy :)

@shanalikhan shanalikhan added this to the v3.3.0 milestone Apr 18, 2019

arnohovhannisyan added some commits Apr 18, 2019

improve(ReleaseNotes):
release-notes.json
----
Update release notes for v3.2.9
Make adding author and PR easier

landing-page.js
----
Implement new method for showing author and PR

@shanalikhan shanalikhan changed the base branch from v3.2.9 to v3.3.0 Apr 19, 2019

@shanalikhan shanalikhan changed the title Login with GitHub [Updated] [WIP] GUI - Login with GitHub Apr 25, 2019

@arnohovhannisyan

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

@shanalikhan once again the commit timeline has been littered with random commits :(. I'm going to open a new PR with only my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.