Skip to content

Shane K Sizer shanesizer-wf

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#48
Shane K Sizer

+1

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

16px is probably worth documenting as a constant

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

Why is this necessary?

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

I don't usually see any value in contractions. It's pretty obvious what this is, but it's just one more mental translation when reading (which happ…

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

All-in-all this looks good. Would really like to see it exist so that you could instantiate more than 1 at a time.

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

requestAnimFrame here instead?

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#24
Shane K Sizer

So, I'm ok with something going in a working state temporarily, but I would definitely prefer to see the Scrollbar create the dom elements itself a…

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#21
Shane K Sizer

+1

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#21
Shane K Sizer

Do brackets mean it's optional?

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#15
Shane K Sizer

+1

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#14
Shane K Sizer

+1 after 1 inline comment added.

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#14
Shane K Sizer

A numerical value might be cooler than 'slow' - very minor thing.

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#14
Shane K Sizer

Get 'er in!!!! Yes!

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#14
Shane K Sizer

Yes please - this is huge perceptually on Desktop!

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#14
Shane K Sizer

Good place for inline comment. We shall never remember after you move on to Netflix

shanesizer-wf commented on issue bower/bower#1061
Shane K Sizer

+1 agreed

shanesizer-wf commented on pull request WebFilings/wf-grunt#2
Shane K Sizer

So we associate the dist directory with a final distributable. Is that the intent?

shanesizer-wf commented on pull request WebFilings/wf-grunt#2
Shane K Sizer

Aspect oriented configuration

shanesizer-wf commented on pull request WebFilings/wf-grunt#1
Shane K Sizer

+1

shanesizer-wf deleted branch inconsistent_interaction_events at WebFilings/wf-uicomponents
Shane K Sizer
Shane K Sizer
Fix Inconsistent Interaction Events
2 commits with 87 additions and 22 deletions
shanesizer-wf commented on pull request WebFilings/wf-uicomponents#8
Shane K Sizer

I would agree this is ugly, and would probably be more clear if written more verbosely. I'm guessing this is to ensure we have an intervening frame…

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#8
Shane K Sizer

I fear lots of booleans.

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#4
Shane K Sizer

+1 - any interest in collapsing commit history?

shanesizer-wf commented on pull request WebFilings/wf-uicomponents#4
Shane K Sizer

16?

shanesizer-wf deleted branch zoomToDoneParameterBug at WebFilings/wf-uicomponents
Something went wrong with that request. Please try again.