Replaces VirtualMachineFleetService with VirtualMachineFleet #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the management of the fleet of virtual machines as a step in the right direction to fix #4. Specifically the PR makes the following changes:
The VirtualMachineFleet creates a number of tasks that matches the number of virtual machines that the app has been configured to start. Each task will sequentially run a virtual machine until the task is cancelled, which will happen either when the user manually stops the fleet of virtual machines or the app is quit.
This provides for much simpler logic that is easier to debug.