Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name shadowing for aliased imports, version 3.3.0. #67

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@Protryon
Copy link
Member

Protryon commented Apr 4, 2019

Fixes #66.

@Protryon Protryon requested a review from bakkot Apr 4, 2019

@Protryon Protryon force-pushed the v3.2.4 branch 4 times, most recently from 22f524b to 402d4e9 Apr 4, 2019

@Protryon Protryon changed the title Fix variable name shadowing for aliased imports, version 3.2.4. Fix variable name shadowing for aliased imports, version 3.3.0. Apr 8, 2019

@Protryon Protryon force-pushed the v3.2.4 branch from 402d4e9 to 4373c7a Apr 8, 2019

import java.util.List;
import java.util.stream.Collectors;

// determines all declared global variables for a module, linked to a scope analysis variable

This comment has been minimized.

Copy link
@bakkot

bakkot Apr 8, 2019

Collaborator

"global" continues to be wrong I think.

@Protryon Protryon force-pushed the v3.2.4 branch 3 times, most recently from e059201 to be3ea4a Apr 8, 2019

@bakkot

bakkot approved these changes Apr 8, 2019

@Protryon Protryon force-pushed the v3.2.4 branch from be3ea4a to 05e15fd Apr 8, 2019

@bakkot bakkot merged commit 1b46ff5 into es2017 Apr 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bakkot bakkot deleted the v3.2.4 branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.