Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-determinism, version 3.3.1 #68

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@Protryon
Copy link
Member

Protryon commented Apr 10, 2019

Fixes non-determinism arising from order-dependent HashTable iteration, version 3.3.1.

@Protryon Protryon requested a review from bakkot Apr 10, 2019

runTest(root, path);
int hash = runTest(root, path);
for (int i = 0; i < 2; ++i) {
int localHash = runTest(root, path);

This comment has been minimized.

Copy link
@bakkot

bakkot Apr 10, 2019

Collaborator

I would prefer we not actually evaluate the test on subsequent runs. Ideally we'd split out the "bundle" portion from the "execute" portion, and only perform the "bundle" portion here.

This comment has been minimized.

Copy link
@Protryon

Protryon Apr 10, 2019

Author Member

Updated

@Protryon Protryon force-pushed the v3.4.0 branch from 4d09ae5 to 5efdc03 Apr 10, 2019

@bakkot

This comment has been minimized.

Copy link
Collaborator

bakkot commented Apr 10, 2019

This seems like a patch, not minor?

@bakkot

bakkot approved these changes Apr 10, 2019

Copy link
Collaborator

bakkot left a comment

LGTM, but should probably be 3.3.1 rather than 3.4.0

@Protryon Protryon force-pushed the v3.4.0 branch from 5efdc03 to d33f590 Apr 11, 2019

@Protryon Protryon changed the title Fix non-determinism, version 3.4.0 Fix non-determinism, version 3.3.1 Apr 11, 2019

@bakkot bakkot merged commit f633863 into es2017 Apr 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bakkot bakkot deleted the v3.4.0 branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.