Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinism without sorting variables #69

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@bakkot
Copy link
Collaborator

bakkot commented Apr 12, 2019

See shapesecurity/shift-java#245. Won't build until that's released.

Instead of sorting all variables within a module, or even across modules, this instead sorts variables within a scope according to their name (which is deterministic) and relies on the list of scopes being deterministic and the list of modules being sorted.

@bakkot bakkot requested a review from Protryon Apr 12, 2019

@Protryon Protryon force-pushed the no-var-sort branch 2 times, most recently from 54b778b to dc80157 Apr 15, 2019

@bakkot bakkot force-pushed the no-var-sort branch from dc80157 to 376dce9 Apr 16, 2019

@bakkot bakkot merged commit 76bdccb into es2017 Apr 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bakkot bakkot deleted the no-var-sort branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.