Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI, version 2.6.1 #98

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@Protryon
Copy link
Member

commented May 1, 2019

While technically a breaking ABI change in and of itself, this PR prevents a breaking ABI change from removing ImmutableList::from(Ljava.util.List;) in favor of Iterable. from(Deque) also had to be merged into from(Iterable) to prevent ambiguous method calls for LinkedList types, and from(ArrayList) followed suit for consistency.

@Protryon Protryon force-pushed the Protryon:fix-abi branch 3 times, most recently from 5cfe492 to f539bec May 1, 2019

@Protryon Protryon force-pushed the Protryon:fix-abi branch from f539bec to 6be1cb4 May 2, 2019

@bakkot

bakkot approved these changes May 2, 2019

@bakkot bakkot merged commit a49740f into shapesecurity:master May 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.