Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back out comparable variables #245

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@bakkot
Copy link
Contributor

bakkot commented Apr 12, 2019

The change to the Variable constructor in #244 was not backwards compatible. This backs that portion of the PR out, with a patch version bump (so please rebase, not squash). It keeps the fix to make the variable list in scope options deterministic, and modifies the test to assert that is the case.

@bakkot bakkot requested a review from Protryon Apr 12, 2019

@Protryon Protryon merged commit 3b3883e into es2017 Apr 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Protryon Protryon deleted the no-var-sort branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.