Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix await identifiers in property names #249

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
3 participants
@Protryon
Copy link
Member

commented May 2, 2019

A port of shift-parser-js#418.

@Protryon Protryon requested review from bakkot and Shilpi3 May 2, 2019

@Shilpi3

Shilpi3 approved these changes May 2, 2019

Copy link
Contributor

left a comment

lgtm. It would be nice to run this PR through gecko tests.

@@ -551,6 +551,11 @@ protected FormalParameters parseParams() throws JsError {
while (!this.eof()) {
if (this.eat(TokenType.ELLIPSIS)) {
rest = parseBindingTarget();
if (this.match(TokenType.ASSIGN)) {

This comment has been minimized.

Copy link
@bakkot

bakkot May 3, 2019

Contributor

Whitespace

@@ -364,14 +364,15 @@ protected BindingProperty parseBindingProperty() throws JsError {

if ((token.type == TokenType.IDENTIFIER || token.type == TokenType.LET || token.type == TokenType.YIELD) && name instanceof StaticPropertyName) {
if (!this.match(TokenType.COLON)) {
if (token.type == TokenType.YIELD && this.allowYieldExpression) {

This comment has been minimized.

Copy link
@bakkot

bakkot May 8, 2019

Contributor

whiiiiitespace

@Protryon Protryon force-pushed the fix-await branch from 2b41552 to bd4a315 May 14, 2019

@Protryon Protryon force-pushed the fix-await branch from bd4a315 to 60c05fd May 14, 2019

@Protryon Protryon merged commit 8b6abaf into es2017 May 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Protryon Protryon deleted the fix-await branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.