Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es2018 impl #414

Merged
merged 29 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@Shilpi3
Copy link
Contributor

commented Mar 13, 2019

No description provided.

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch from 6de5236 to 89902da Mar 13, 2019

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch 2 times, most recently from 75e0934 to 13b3b5b Apr 3, 2019

Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js
Show resolved Hide resolved src/parser.js

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch 7 times, most recently from 8661725 to 244f3b5 Apr 9, 2019

Shilpi3 added some commits Mar 13, 2019

Added regexp dotAll flag
Added object rest(assignment)
Added objcet rest(binding)
Added object spread
Update to es2018
update test expectations for test262-parser-tests

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch from 244f3b5 to c99dcb1 Apr 15, 2019

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch from 0e06e25 to e334142 Apr 18, 2019

@Protryon Protryon referenced this pull request Apr 22, 2019

Closed

ES2018 Implementation #415

Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved .gitignore Outdated
Show resolved Hide resolved run-my-js.js Outdated
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated

@Shilpi3 Shilpi3 changed the base branch from es2017 to es2018 May 3, 2019

Show resolved Hide resolved src/parser.js Outdated

@Shilpi3 Shilpi3 force-pushed the Shilpi3:es2018-impl branch from 14941f6 to 2a28351 May 3, 2019

@@ -66,6 +55,14 @@ export default {
// https://github.com/tc39/test262-parser-tests/issues/15
'14eaa7e71c682461.js',
'aca911e336954a5b.js',

// errors that michael disagrees with (function name `eval`/`arguments`/`package`/`static` invalid for strict mode function bodies)

This comment has been minimized.

Copy link
@bakkot

bakkot May 8, 2019

Contributor

Is there an open issue for this? If not you should open one. This comment should refer to an issue, not a person.

Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated
Show resolved Hide resolved src/parser.js Outdated

Shilpi3 added some commits May 9, 2019

@bakkot

bakkot approved these changes May 9, 2019

@bakkot bakkot merged commit bd19570 into shapesecurity:es2018 May 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.