Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bug #416 Bug #417 #418

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@Shilpi3
Copy link
Contributor

commented May 1, 2019

Refactored parseLeftHandSideExpression to accomodate parseParams in Arrow functions

@Shilpi3 Shilpi3 force-pushed the fix-bug-416-417 branch 2 times, most recently from a5a7da7 to 6721ebd May 1, 2019

@Shilpi3 Shilpi3 requested a review from bakkot May 1, 2019

Show resolved Hide resolved src/parser.js Outdated

@Shilpi3 Shilpi3 force-pushed the fix-bug-416-417 branch from 6721ebd to 5b7bc70 May 2, 2019

Show resolved Hide resolved src/parser.js Outdated
@bakkot

bakkot approved these changes May 2, 2019

Copy link
Contributor

left a comment

Looks good other than small comments above.

@Shilpi3 Shilpi3 force-pushed the fix-bug-416-417 branch from 5b7bc70 to b0f3ab7 May 2, 2019

Show resolved Hide resolved src/parser.js
parseLeftHandSideExpression to throw error for rest initialization in…
… Arrow function parameters

Disallow await as Object binding property in the formal parameters in  async context

@Shilpi3 Shilpi3 force-pushed the fix-bug-416-417 branch from b0f3ab7 to b829213 May 2, 2019

@bakkot bakkot merged commit ee8303e into es2017 May 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bakkot bakkot deleted the fix-bug-416-417 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.