UnknownDirective and UseStrictDirective overlap #11

Closed
michaelficarra opened this Issue Jan 2, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@michaelficarra
Member

michaelficarra commented Jan 2, 2015

An UnknownDirective with value "use strict" would re-parse as a UseStrictDirective. I think it was a bad idea splitting these things out. For the next version, I think we should have a single Directive node.

@ikarienator

This comment has been minimized.

Show comment
Hide comment
@ikarienator

ikarienator Jan 2, 2015

Member

Not exactly... correct me if I'm wrong: the value is the unescaped value of the string literal. We might need to rename value to raw or have a boolean raw flag on it.

Member

ikarienator commented Jan 2, 2015

Not exactly... correct me if I'm wrong: the value is the unescaped value of the string literal. We might need to rename value to raw or have a boolean raw flag on it.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Jan 5, 2015

Member

The value is the raw representation of the directive.

Member

michaelficarra commented Jan 5, 2015

The value is the raw representation of the directive.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Jan 5, 2015

Member

Fixed on es6 branch.

Member

michaelficarra commented Jan 5, 2015

Fixed on es6 branch.

@michaelficarra michaelficarra modified the milestone: ES6 Jan 8, 2015

@michaelficarra michaelficarra referenced this issue in shapesecurity/shift-parser-js Jan 8, 2015

Closed

add support for ES6 #8

30 of 31 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment