Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnknownDirective and UseStrictDirective overlap #11

Closed
michaelficarra opened this issue Jan 2, 2015 · 3 comments
Closed

UnknownDirective and UseStrictDirective overlap #11

michaelficarra opened this issue Jan 2, 2015 · 3 comments
Labels
Milestone

Comments

@michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented Jan 2, 2015

An UnknownDirective with value "use strict" would re-parse as a UseStrictDirective. I think it was a bad idea splitting these things out. For the next version, I think we should have a single Directive node.

@ikarienator
Copy link
Member

@ikarienator ikarienator commented Jan 2, 2015

Not exactly... correct me if I'm wrong: the value is the unescaped value of the string literal. We might need to rename value to raw or have a boolean raw flag on it.

@michaelficarra
Copy link
Member Author

@michaelficarra michaelficarra commented Jan 5, 2015

The value is the raw representation of the directive.

@michaelficarra
Copy link
Member Author

@michaelficarra michaelficarra commented Jan 5, 2015

Fixed on es6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.