consider splitting ForInStatement with binding and ForInStatement with VariableDeclaration #8

Closed
michaelficarra opened this Issue Dec 27, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@michaelficarra
Member

michaelficarra commented Dec 27, 2014

The reasoning behind this is that a ForInStatement with a VariableDeclaration left may only have a single declarator. This must be validated with our validator. Instead, we should just represent it as a VariableDeclarationKind and a VariableDeclarator. The downside to this would be that uniform VariableDeclaration handling would not apply in this case. I'm not sure which is better.

@michaelficarra michaelficarra modified the milestone: ES6 Jan 8, 2015

@michaelficarra michaelficarra referenced this issue in shapesecurity/shift-parser-js Jan 8, 2015

Closed

add support for ES6 #8

30 of 31 tasks complete
@ikarienator

This comment has been minimized.

Show comment
Hide comment
@ikarienator

ikarienator Jan 17, 2015

Member

I will go a step further to separate all four for statements and remove the Either kind.

Member

ikarienator commented Jan 17, 2015

I will go a step further to separate all four for statements and remove the Either kind.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Mar 11, 2015

Member

@ikarienator Thoughts on this? I am neutral on it, and trying to avoid extra work before publishing the ES6 standard. Close?

Member

michaelficarra commented Mar 11, 2015

@ikarienator Thoughts on this? I am neutral on it, and trying to avoid extra work before publishing the ES6 standard. Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment