Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider splitting ForInStatement with binding and ForInStatement with VariableDeclaration #8

michaelficarra opened this issue Dec 27, 2014 · 2 comments


Copy link

@michaelficarra michaelficarra commented Dec 27, 2014

The reasoning behind this is that a ForInStatement with a VariableDeclaration left may only have a single declarator. This must be validated with our validator. Instead, we should just represent it as a VariableDeclarationKind and a VariableDeclarator. The downside to this would be that uniform VariableDeclaration handling would not apply in this case. I'm not sure which is better.

@michaelficarra michaelficarra modified the milestone: ES6 Jan 8, 2015
Copy link

@ikarienator ikarienator commented Jan 17, 2015

I will go a step further to separate all four for statements and remove the Either kind.

Copy link
Member Author

@michaelficarra michaelficarra commented Mar 11, 2015

@ikarienator Thoughts on this? I am neutral on it, and trying to avoid extra work before publishing the ES6 standard. Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.