Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1432, move inner class CommandExecutor out for SkyWalking intercept #1433

Merged
merged 4 commits into from Nov 6, 2018
Merged

#1432, move inner class CommandExecutor out for SkyWalking intercept #1433

merged 4 commits into from Nov 6, 2018

Conversation

tuohai666
Copy link
Member

Fixes #1432 .

@coveralls
Copy link

coveralls commented Nov 6, 2018

Pull Request Test Coverage Report for Build 5568

  • 2 of 45 (4.44%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.7%) to 68.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/frontend/mysql/MySQLFrontendHandler.java 0 2 0.0%
sharding-proxy/src/main/java/io/shardingsphere/shardingproxy/frontend/mysql/CommandExecutor.java 2 43 4.65%
Files with Coverage Reduction New Missed Lines %
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/parser/dialect/OracleStatementAdvancedParser.java 1 87.5%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/parser/dialect/PostgreStatementAdvancedParser.java 1 87.5%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/parser/dialect/MySQLStatementAdvancedParser.java 1 87.5%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/parser/dialect/SQLServerStatementAdvancedParser.java 1 87.5%
Totals Coverage Status
Change from base Build 5558: 0.7%
Covered Lines: 8174
Relevant Lines: 11997

💛 - Coveralls

@terrymanu terrymanu merged commit efa7f62 into apache:dev Nov 6, 2018
@terrymanu terrymanu added this to the 3.1.0.M1 milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants