Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

CM integration throws a lot of errors #182

Closed
oskarkrawczyk opened this Issue · 7 comments

5 participants

@oskarkrawczyk

It seems like the CM integration is broken.

There's a lot of Uncaught TypeError: Object #<Doc> has no method 'getValue', there are some Uncaught TypeError: Cannot read property 'text' of null.

Additionally the synchronization gets broken once you select all lines of code and delete them. But that's probably because of the aforementioned JS errors.

Is CM support still something you want to maintain?

@josephg
Owner

I know. I don't know who's broken CM, but I'm quite annoyed that people have been submitting pull requests without checking if they break the build.

This is the reason why I haven't updated npm in awhile. Its time for a git bisect.

@nareshv

+1

it was working for the past couple of days. Seems broken now.

@netsgnut

I have recently encountered this same bug at fc07166, with CM 3.12. When replacing multiline texts, it first emits Uncaught TypeError: Cannot read property 'text' of null, followed by a series of Text does not match!.

The former error is emitted from https://github.com/josephg/ShareJS/blob/fc07166/src/client/cm.coffee#L24, which was caused by a null returned at https://github.com/marijnh/CodeMirror/blob/v3.12/lib/codemirror.js#L2889.

@josephg
Owner

I just pulled 9ffc95b to upgrade to the latest CM. Does that fix it?
Ping @mluto @nornagon

@luto

No, still throws Text does not match!.. :-/
Edit: Uncaught TypeError: Cannot read property 'text' of null seems to be gone, though.

@oskarkrawczyk

As for the errors I've mentioned. These are gone.

@josephg
Owner

Great.

@josephg josephg closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.