Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShareJS 0.7 - shout #297

Open
hatpick opened this issue Mar 2, 2014 · 4 comments
Open

ShareJS 0.7 - shout #297

hatpick opened this issue Mar 2, 2014 · 4 comments

Comments

@hatpick
Copy link
Contributor

hatpick commented Mar 2, 2014

Is there any replacement for 'shout' from 0.6.x, if yes what is it and if no is it possible to add something like that again?

@wmertens
Copy link
Contributor

wmertens commented Mar 4, 2014

Unfortunately I don't have time to work on this - the changes needed are
pretty small in code size but need to be in the right places. Basically
shouts need to be passed to all clients without hitting the database or
changing the document.

Here's the code changes that were needed for 0.6:
https://github.com/share/ShareJS/pull/57/files

See the pull discussion for some alternative approaches.

On Sun, Mar 2, 2014 at 3:53 AM, Soroush notifications@github.com wrote:

Is there any replacement for 'shout' from 0.6.x, if yes what is it and if
no is it possible to add something like that again?

Reply to this email directly or view it on GitHubhttps://github.com//issues/297
.

@josephg
Copy link
Owner

josephg commented Mar 4, 2014

Yeah I'll add back a 'shout'-like message as part of the presence code. Its a lot more complicated now that livedb can scale.

@hatpick
Copy link
Contributor Author

hatpick commented Mar 5, 2014

Great, I was using it for awareness-related purposes.

@hatpick hatpick closed this as completed Mar 5, 2014
@josephg
Copy link
Owner

josephg commented Mar 5, 2014

... I'm going to leave this issue open until we add the functionality back.

@josephg josephg reopened this Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants