Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with CoffeeScript 1.3.x #84

Closed
ggoodman opened this issue Apr 11, 2012 · 9 comments
Closed

Incompatibility with CoffeeScript 1.3.x #84

ggoodman opened this issue Apr 11, 2012 · 9 comments

Comments

@ggoodman
Copy link

Installing CoffeeScript 1.3.x will prevent ShareJS from running due to the new limitations on conditional assignment using the ?= operator.

@lukeholder
Copy link

anyway to fix this simply?

@CrypticSwarm
Copy link
Contributor

A quick fix would be to change the package.json file so that it depends on coffee-script 1.2.x instead of >1.1.0

@lukeholder
Copy link

i changed the share package.json but the error still occurs... whats the recheck deps command in npm?

@CrypticSwarm
Copy link
Contributor

Just tested this: edit the package.json file and while in the same directory as the package.json file run:

npm install ./

This downgraded coffee to 1.2.0

@ggoodman
Copy link
Author

There is the same issue with browserchannel for me as well. To fix, I forked ShareJS and browserchannel and updated the former to point to the fork of the latter. I changed both package.json to use coffee-script 1.2.x.

@josephg
Copy link
Owner

josephg commented Apr 15, 2012

I've fixed the sharejs build.

@josephg josephg closed this as completed Apr 15, 2012
@josephg
Copy link
Owner

josephg commented Apr 15, 2012

... And browserchannel seems to be working fine? If you have problems there, please file issues on the project.

@edmellum
Copy link

Could you bump the version so we can have this fix on NPM?

@sandro-pasquali
Copy link

Heya,

Fix works great! Unfortunately this needs to be bumped on NPM, as sharejs is usually installed via that channel.

Possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants