Random fixes required when I first checked out the project.

[my8bird]

The only thing I see that could be problematic (through my naive eyes) would be the redis package as a dependency. In order to run the project redis is required so it seemed that this needed to be there.

Otherwise, this ensures that cake uses the projects coffee executable instead of the system wide one and adds some hooks to ensure the lib directory is up to date at crucial points.

[wmertens]

Actually the redis dependency is optional... And if the system wide coffee matches the required version it won't be installed locally. It would be better to define a PATH that includes the node_modules here as well as the normal path and just call coffee. That way the shell will use the first one it finds.

[wmertens]

iPhone button booboo

[my8bird]

I will torch the redis thing, it must just be the sharejs example that requires it. Also, I will look into the PATH extension idea (pretty sweet to know if that works as I can use it on some other projects).

[my8bird]

@wmertens Updated to fix the issues you found.

[CrypticSwarm]

Ideally just uses the prepublish, and not postinstall. Coffee should be moved as a dev dep only. It shouldn't be needed to run the server.

[CrypticSwarm]

Ideally just uses the prepublish, and not postinstall. Coffee should be moved as a dev dep only. It shouldn't be needed to run the server.

[josephg]

@wmertens the lib directory already isn't part of git. The package's root in npm is index.js, which looks like this:

require('coffee-script');
module.exports = require('./src');

This means cake build isn't needed at all, and coffeescript is needed when you run the server.

The lib directory is only used for two purposes:

• Building the webclient (via cake webclient). The webclient build concatenates a bunch of the client .js files together then uglifies them.
• Debugging. When there's a crash, the line numbers are from the javascript file, not the .coffee file. So I often end up referring to the .js files in lib/ to figure out what line of coffeescript the crash is referring to.

[wmertens]

So should the postinstall "cake build" be removed and the prepublish have "cake webclient"?

[wmertens]

Thanks!

[josephg]

Build is broken.

http://travis-ci.org/#!/josephg/ShareJS

[wmertens]

Yup - it's because of sockjs, it broke as soon as I updated webclient a couple commits later. I have something that no longer breaks the tests but lets them last forever. I'm getting closer :-)