have failed compiles warn rather than be an error

overleaf · Nov 23, 2018 · 49f3b7d · 49f3b7d
1 parent f1ab938
commit 49f3b7d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/coffee/CompileController.coffee b/app/coffee/CompileController.coffee
@@ -33,7 +33,7 @@ module.exports = CompileController =
 						else
 							status = "error"
 							code = 500
-							logger.error err: error, project_id: request.project_id, "error running compile"
+							logger.warn err: error, project_id: request.project_id, "error running compile"
 
 					else
 						status = "failure"
@@ -42,7 +42,7 @@ module.exports = CompileController =
 								status = "success"
 
 						if status == "failure"
-							logger.err project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated"
+							logger.warn project_id: request.project_id, outputFiles:outputFiles, "project failed to compile successfully, no output.pdf generated"
 
 						# log an error if any core files are found
 						for file in outputFiles

diff --git a/test/unit/coffee/CompileControllerTests.coffee b/test/unit/coffee/CompileControllerTests.coffee
@@ -14,7 +14,7 @@ describe "CompileController", ->
 					clsi:
 						url: "http://clsi.example.com"
 			"./ProjectPersistenceManager": @ProjectPersistenceManager = {}
-			"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub() }
+			"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:sinon.stub(), warn: sinon.stub()}
 		@Settings.externalUrl = "http://www.example.com"
 		@req = {}
 		@res = {}