New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy version to package.json to fix install. #53

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
3 participants
@cirosantilli
Contributor

cirosantilli commented Feb 25, 2014

Without a dummy version, installation fails. I tried both npm install and nmp install ..

Seems to be what npm documents: https://www.npmjs.org/doc/files/package.json.html

The most important things in your package.json are the name and version fields. Those are actually required,

jpallen added a commit that referenced this pull request Feb 25, 2014

Merge pull request #53 from cirosantilli/add-dummy-version
Add dummy version to package.json to fix install.

@jpallen jpallen merged commit 61bb54a into sharelatex:master Feb 25, 2014

@jpallen

This comment has been minimized.

Contributor

jpallen commented Feb 25, 2014

Thanks!

@henryoswald

This comment has been minimized.

Contributor

henryoswald commented Feb 25, 2014

@cirosantilli thats a new one, what version of npm are you running out of interest.

@cirosantilli cirosantilli deleted the cirosantilli:add-dummy-version branch Feb 25, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Feb 25, 2014

Ahhh, I was using an outdated 0.9.9 Node with XXX npm... now that I correctly used node 0.10.26 with npm 1.4.3 it works even without the version.

Sorry about that, it was stupid. Not sure what to make of the docs though.

I also tested now with node 0.10.0 and it still works without the version, so this can be undone if you think better.

@jpallen

This comment has been minimized.

Contributor

jpallen commented Feb 25, 2014

npm expects a version to be provided, so I suppose we should provide one
:). Eventually we'll start making release versions, but until then we'll
just keep the version at 0.0.1.

On Tue, Feb 25, 2014 at 4:51 PM, Ciro Santilli notifications@github.comwrote:

Ahhh, I was using an outdated 0.9.9 Node with XXX npm... now that I
correctly used node 0.10.26 with npm 1.4.3 it works even without the
version.

Sorry about that, it was stupid. Not sure what to make of the docs though.

I also tested now with node 0.10.0 and it still works without the version,
so this can be undone if you think better.

Reply to this email directly or view it on GitHubhttps://github.com//pull/53#issuecomment-36029161
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment