Permalink
Browse files

added some javadoc. Corrected .ruleset and android_pmd_ruleset.xml, as

had wrong classref to Xpathrule
  • Loading branch information...
1 parent ce88f5e commit 36e4b45e4c21675fd092854474775c443f00e9d7 @shareme committed Jan 21, 2012
Showing with 17 additions and 6 deletions.
  1. +3 −3 .ruleset
  2. +3 −3 android_pmd_ruleset.xml
  3. +11 −0 src/com/github/shareme/bddandroid/BDDAndroidActivity.java
View
@@ -15,7 +15,7 @@
<rule name="CallSuperFirst"
since="4.2.5" language="java"
message="super should be called at the start of the method"
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#CallSuperFirst">
<description>Super should be called at the start of the method</description>
<priority>3</priority>
@@ -57,7 +57,7 @@ public class DummyActivity extends Activity {
<rule name="CallSuperLast"
since="4.2.5" language="java"
message="super should be called at the end of the method"
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#CallSuperLast">
<description>Super should be called at the end of the method</description>
<priority>3</priority>
@@ -99,7 +99,7 @@ public class DummyActivity extends Activity {
<rule name="DoNotHardCodeSDCard"
since="4.2.6" language="java"
message="Do not hardcode /sdcard."
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#DoNotHardCodeSDCard">
<description>Use Environment.getExternalStorageDirectory() instead of "/sdcard"</description>
<priority>3</priority>
View
@@ -15,7 +15,7 @@
<rule name="CallSuperFirst"
since="4.2.5" language="java"
message="super should be called at the start of the method"
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#CallSuperFirst">
<description>Super should be called at the start of the method</description>
<priority>3</priority>
@@ -57,7 +57,7 @@ public class DummyActivity extends Activity {
<rule name="CallSuperLast"
since="4.2.5" language="java"
message="super should be called at the end of the method"
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#CallSuperLast">
<description>Super should be called at the end of the method</description>
<priority>3</priority>
@@ -99,7 +99,7 @@ public class DummyActivity extends Activity {
<rule name="DoNotHardCodeSDCard"
since="4.2.6" language="java"
message="Do not hardcode /sdcard."
- class="net.sourceforge.pmd.lang.rule.XPathRule"
+ class="net.sourceforge.pmd.rules.XPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/java/android.html#DoNotHardCodeSDCard">
<description>Use Environment.getExternalStorageDirectory() instead of "/sdcard"</description>
<priority>3</priority>
@@ -26,6 +26,7 @@
import android.view.Window;
import android.widget.TextView;
+// TODO: Auto-generated Javadoc
/**
* This is a simple LunarLander activity that houses a single LunarView. It
* demonstrates...
@@ -36,18 +37,26 @@
* </ul>
*/
public class BDDAndroidActivity extends Activity {
+
+ /** The Constant MENU_EASY. */
private static final int MENU_EASY = 1;
+ /** The Constant MENU_HARD. */
private static final int MENU_HARD = 2;
+ /** The Constant MENU_MEDIUM. */
private static final int MENU_MEDIUM = 3;
+ /** The Constant MENU_PAUSE. */
private static final int MENU_PAUSE = 4;
+ /** The Constant MENU_RESUME. */
private static final int MENU_RESUME = 5;
+ /** The Constant MENU_START. */
private static final int MENU_START = 6;
+ /** The Constant MENU_STOP. */
private static final int MENU_STOP = 7;
/** A handle to the thread that's actually running the animation. */
@@ -109,6 +118,8 @@ public boolean onOptionsItemSelected(MenuItem item) {
case MENU_HARD:
mLunarThread.setDifficulty(LunarThread.DIFFICULTY_HARD);
return true;
+ default:
+ break;
}
return false;

0 comments on commit 36e4b45

Please sign in to comment.