Skip to content

Conversation

@Gnito
Copy link

@Gnito Gnito commented Aug 23, 2022

Currently released as 6.0.1-RC

2 fixes:

Remove vendor code chunk

splitChunks was reintroduced prematurely.
CRA 5 is discussing reintroducing it, but the previous (CRA4) style does not work with 'async' marked thunk functions.

I.e. this was removed:

      // Sharetribe custom: create vendor chunk
      // CRA v5, removed this splitChunks feature, but they are planning to reintroduce it.
      // https://github.com/facebook/create-react-app/pull/11763
      splitChunks: isEnvDevelopment
        ? undefined
        : {
            chunks: 'all',
          },      

Error when using env variable: GENERATE_SOURCEMAP=false

GENERATE_SOURCEMAP=false caused an error since it modified the structure of webpack.config.js

Gnito added 3 commits August 23, 2022 17:38
since it affected to the structure of webpack.config.js
CRA 5 is discussing to reintroduce it, but the previous (CRA4) style does not work
with 'async' marked thunk functions.
sharetribe/ftw-daily#1545

We decided to follow CRA's releases instead of branch out wiht own experiments.
@Gnito Gnito merged commit 7acd49b into master Aug 29, 2022
@Gnito Gnito deleted the fix-generate-sourcemap-and-revert-splitChunk branch August 29, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants