Update devise 3.5 #1675
Merged
Update devise 3.5 #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rap1ds
force-pushed
the
update-devise-3.5
branch
from
199642a
to
80e5a7f
Compare
Merged
| @@ -65,6 +65,9 @@ | |||
|
|
|||
| resources :communities, only: [:new, :create] | |||
|
|
|||
|
|
|||
| devise_for :people, only: :omniauth_callbacks, controllers: { omniauth_callbacks: "sessions"} | |||
There was a problem hiding this comment.
Can you quickly explain the effects and idea of pulling omniauth_callbacks here?
There was a problem hiding this comment.
I followed the instructions Devise gave me:
/Users/mikko/.rvm/gems/ruby-2.1.2/gems/devise-3.5.4/lib/devise/rails/routes.rb:418:in `devise_omniauth_callback':
Devise does not support scoping OmniAuth callbacks under a dynamic segment
and you have set "/(/:locale)/people". You can work around by passing
`skip: :omniauth_callbacks` to the `devise_for` call and extract omniauth
options to another `devise_for` call outside the scope. Here is an example:
devise_for :users, only: :omniauth_callbacks, controllers: {omniauth_callbacks: 'users/omniauth_callbacks'}
scope '/(:locale)', locale: /ru|en/ do
devise_for :users, skip: :omniauth_callbacks
end
(RuntimeError)
There was a problem hiding this comment.
To my understanding this doesn't have any major effect. The path for the omniauth callback is fetched from person_omniauth_authorize_path method, so I guess from now on that method returns a path without any locale in it?
Anyway, I tested this and FB auth seems to be working normally.
This change removes the warning:
`devise_omniauth_callback': Devise does not support scoping OmniAuth callbacks under a dynamic segment
and you have set "/(/:locale)/people". You can work around by passing
`skip: :omniauth_callbacks` to the `devise_for` call and extract omniauth
options to another `devise_for` call outside the scope. Here is an example:
devise_for :users, only: :omniauth_callbacks, controllers: {omniauth_callbacks: 'users/omniauth_callbacks'}
scope '/(:locale)', locale: /ru|en/ do
devise_for :users, skip: :omniauth_callbacks
end
rap1ds
force-pushed
the
update-devise-3.5
branch
from
80e5a7f
to
742bfbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Devise gem to 3.5
TODO