Stripe integration #3018
Merged
Stripe integration #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdis
force-pushed
the
stripe-integration
branch
from
0de6ce0
to
8913504
Compare
… errors; bank account format hints
…d cards; optional support for stripe connect
… is different; show spinner in payment form
…ry stripe connect, stored card view, balance, toggles
…ature flag checks
…, yet without feature flag
valdis
force-pushed
the
stripe-integration
branch
4 times, most recently
from
ba2d19c
to
35be972
Compare
…ixes-2 Stripe checkout additional fixes 2
…ixes Stripe checkout additional fixes
…n minimal commission
|
We have started implementing Stripe a while ago, and believe this PR could benefit from some refactoring, specially on the payments_preference_controller I think that class should delegate some behavior to other classes. If you think about adding a new payment method in the future you will see that class becomes hard to maintain pretty fast. I can give more specific comments via a review if you guys want. In any case, thank you for the efforts, Stripe is a great addition to Sharetribe. We have a fork from Sharetribe which we used to build our Marketplace and it's been great for us. |
Stripe admin ui fixes 3
…lags-ui-fixes Stripe integration feature flags ui fixes
Stripe additional countries
valdis
dismissed stale reviews from sktoiva and bladealslayer
All mentioned issues have been addressed
valdis
force-pushed
the
stripe-integration
branch
from
29993bd
to
6ab45cc
Compare
…ve just been set up
valdis
force-pushed
the
stripe-integration
branch
from
6ab45cc
to
4172486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.