Don't set crossterms underline color/ Fix blink #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were observing blinking as an artifact for colored output in several terminal emulators (e.g. Windows Terminal, Mac's Terminal.app) nushell/nushell#6172 (comment) To resolve that, don't specifically set the underline color as it is optional.
This was referenced Aug 2, 2022
sholderbach
added a commit
to sholderbach/nushell
that referenced
this pull request
Aug 2, 2022
Unreleased patch for the `lscolors` -> `crossterm` translation, where I introduced a bug/incompatibility with several terminal emulators causing blinking nushell#6172 (comment) Refers to patch, can be replaced once a new `lscolors` version is released: sharkdp/lscolors#51
6 tasks
sholderbach
added a commit
to nushell/nushell
that referenced
this pull request
Aug 2, 2022
Unreleased patch for the `lscolors` -> `crossterm` translation, where I introduced a bug/incompatibility with several terminal emulators causing blinking #6172 (comment) Refers to patch, can be replaced once a new `lscolors` version is released: sharkdp/lscolors#51
tavianator
approved these changes
Aug 2, 2022
|
Thank you! I'll try to make a release later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were observing blinking as an artifact for colored output in several
terminal emulators (e.g. Windows Terminal, Mac's Terminal.app)
nushell/nushell#6172 (comment)
To resolve that, don't specifically set the underline color as it is
optional.