Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PureScript 0.12 #33

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Conversation

abaco
Copy link
Contributor

@abaco abaco commented Jul 16, 2018

Just a straightforward update of dependencies and a couple of minor fixes.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@sharkdp sharkdp merged commit 203bb4c into sharkdp:master Jul 17, 2018
@sharkdp
Copy link
Owner

sharkdp commented Jul 17, 2018

Were you able to run the test-suite? I get the following:

> pulp test
[..]

* Running tests...
internal/modules/cjs/loader.js:573
    throw err;
    ^

Error: Cannot find module '../Control.Semigroupoid/index.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:571:15)
    at Function.Module._load (internal/modules/cjs/loader.js:497:25)
    at Module.require (internal/modules/cjs/loader.js:626:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/home/shark/Dropbox/Informatik/purescript/purescript-quantities/output/Control.Category/index.js:3:28)
    at Module._compile (internal/modules/cjs/loader.js:678:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
    at Module.load (internal/modules/cjs/loader.js:589:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
    at Function.Module._load (internal/modules/cjs/loader.js:520:3)
* ERROR: Subcommand terminated with exit code 1

@abaco
Copy link
Contributor Author

abaco commented Jul 17, 2018

Yes, the tests run fine to me! I've just checked again: removed bower_components and node_modules, reinstalled the dependencies, and run the tests. It works. Let me know if I can help in debugging.

@sharkdp
Copy link
Owner

sharkdp commented Jul 18, 2018

I have no idea what went wrong. Repeated the same process today and it works. Thanks again!

Released as v8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants