Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed Ramp up method #57

Closed
3 of 6 tasks
tthiery opened this issue Jul 14, 2020 · 2 comments
Closed
3 of 6 tasks

Speed Ramp up method #57

tthiery opened this issue Jul 14, 2020 · 2 comments
Assignees
@tthiery
Labels
area-device-motor enhancement New feature or request
Milestone
v3.3 (non-breaking)

Comments

@tthiery
Copy link
Member

tthiery commented Jul 14, 2020 •
edited
Loading

  • First, check if this is actually different to acceleration profiles
  • Motor Power Ramp
  • Motor Speed Ramp (Add LinearSpeedChange #89)
  • Motor Position Ramp (e.g. do x degrees and ramp speed up meanwhile)
  • Use acceleration profiles if right motor, method and time limitation (with config option to avoid) (does not work, command does not transition well to next speed for time)
  • Add Cancellation Token support

Lesson Learnt from #48
@tthiery tthiery added the enhancement New feature or request label Jul 14, 2020
@tthiery tthiery added this to the v2.1 milestone Jul 14, 2020
@tthiery tthiery modified the milestones: v2.1, v2.2 Jul 28, 2020
@tthiery
Copy link
Member Author

tthiery commented Aug 9, 2020 •
edited
Loading

The LWP acceleration profiles are described as a linear ramp of speed. It is time wise limited to 10s and limited to TachoMotor and AbsoluteMotor.

They are identical in sense of linear increase of speed. Acceleration Profiles should definitely be used (reduce BLE traffice etc).

However, for BasicMotor or avoiding the 10s limitation, this proposal still make sense.

@tthiery tthiery modified the milestones: v2.2, v3.0 - Breaking Changes Aug 17, 2020
tthiery added a commit that referenced this issue Sep 2, 2020
@tthiery
Add LinearSpeedChange
529a87d 
- Add base class for iterative changes
- Add example

#57 (non-breaking)
@tthiery tthiery mentioned this issue Sep 2, 2020
Merged
tthiery added a commit that referenced this issue Dec 23, 2020
@tthiery
Finish RampUp
57109a0 
- Waiting Time is adjusted to command execution time (IO)

#57 non-breaking
@tthiery tthiery self-assigned this Dec 23, 2020
@tthiery
Copy link
Member Author

tthiery commented Dec 23, 2020

Close this with RampUp on Speed.

tthiery added a commit that referenced this issue Dec 23, 2020
@tthiery
Add LinearSpeedChange (#89)
0cac6c0 
Add LinearSpeedChange

- Add base class for iterative changes
- Add example
- Waiting Time is adjusted to command execution time (IO)

#57 non-breaking
@tthiery tthiery closed this as completed Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthiery tthiery

Labels
area-device-motor enhancement New feature or request
Projects
None yet
Milestone
v3.3 (non-breaking)
Development

No branches or pull requests
1 participant
@tthiery