Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bouncer.refresh_token as well as bouncer.token. #46

Merged
merged 1 commit into from Jul 15, 2015

Conversation

recurser
Copy link
Contributor

Passes bouncer.refresh_token from heroku-oauth so that fresh tokens can be obtained in the future.

@wuputah
Copy link
Contributor

wuputah commented Jun 22, 2015

Thanks Dave. I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

cc/ @rhyselsmore do you see any issues here?

@recurser
Copy link
Contributor Author

Hi @wuputah,

I purposely did not include refresh tokens for security reasons, but since this is behind expose_token I think it's okay to include refresh tokens.

I could put it behind something like expose_refresh_token if you'd prefer, so it needs to be explicitly opted-into?

@recurser
Copy link
Contributor Author

Hi @wuputah / @rhyselsmore - any further thoughts on this?

@wuputah
Copy link
Contributor

wuputah commented Jul 15, 2015

:shipit:

wuputah added a commit that referenced this pull request Jul 15, 2015
Pass bouncer.refresh_token as well as bouncer.token.
@wuputah wuputah merged commit fc63565 into sharpstone:master Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants