New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomisations - clear more rand_structured bottlenecks #685

Closed
shawnlaffan opened this Issue Feb 24, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@shawnlaffan
Owner

shawnlaffan commented Feb 24, 2018

profiling shows some bottlenecks in Biodiverse::Randomise::rand_structured. These need to be opened up.

@shawnlaffan shawnlaffan added this to the Release_2.1 milestone Feb 24, 2018

@shawnlaffan shawnlaffan self-assigned this Feb 24, 2018

shawnlaffan added a commit that referenced this issue Feb 24, 2018

Use unfilled groups directly rather than rebuilding it each time
We were setting the target groups to the full possible set and
then trimming out the filled groups.  It makes more sense to
use the unfilled groups, since we are tracking them anyway.

updates #685

shawnlaffan added a commit that referenced this issue Feb 24, 2018

shawnlaffan added a commit that referenced this issue Feb 24, 2018

remove some old debugging code
Gives a slightly shorter and neater sub.

Updates #685

shawnlaffan added a commit that referenced this issue Feb 24, 2018

Avoid the need for a copied hash
It was only used to check deletions, so we can build one as we go instead.
Copying the original hash was a substantial part of the run time under profiling.

Also clear up some commentary.

Updates #685

shawnlaffan added a commit that referenced this issue Feb 24, 2018

@shawnlaffan

This comment has been minimized.

Owner

shawnlaffan commented Feb 24, 2018

Mark as fixed.

The remaining known bottleneck can be handled in its own issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment