Non blocking poll recv #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some zmq::socket_base::send() and zmq::socket_base::recv() methods cause deprecation warnings. Use updated methods instead.
By default, zmq::socket_base::recv() blocks until a message is received, but there is no guarantee of timely delivery. However, sync_agent() uses recv() to synchronize with agents, and recv() has been observed in some cases to block completed reception of the "ack" until all agents have finished their entire workload, causing the primary mcperf's load generation to start afterwards. This causes some serial execution instead of fully-parallel concurrency, which results in a higher QPS and longer latency. Instead of relying on recv() to unblock quickly, poll non-blocking recv().
shaygalon
approved these changes
Sep 16, 2022
shaygalon
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
These patches address some issues I have been having with performance reproducibility.
The first patch addresses the warnings about using deprecated methods in zmq.hpp when compiled using C++11.
The second patch improves synchronization between the leader mcperf and its agents in order to reliably have fully concurrent load generation.
James