/ssh-chat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Full rewrite, candidate for v1.0 #87

Merged
merged 66 commits into from Jan 20, 2015

Conversation

Reviewers
No reviews
Assignees

@shazow shazow

Labels
Projects
None yet
Milestone
  v1.0
5 participants
@shazow @aquilax @SamMauldin @nickpresta @mcroydon
@shazow
Owner

shazow commented Dec 23, 2014

  • Separated chat-specific stuff into a chat submodule that knows nothing about the transport.
  • Separated ssh server specific stuff into an sshd submodule that knows nothing about chat.
  • Some things actually have tests!
  • Need to implement the glue between them (old code still lives there, will be replaced).
  • Many of the old squashed bugs are back, specifically hanging server and crashes. Need to fix those before replacing the current version. Should be easier to write tests for these scenarios now.

Everything is different, so would be cool if new PRs were against this branch rather than new branch, but ¯_(ツ)_/¯.

Related: #76
@shazow

This comment has been minimized.

Show comment
Hide comment
@shazow

shazow Dec 24, 2014

Owner

Pinging top contributors, in case you feel like looking around and giving some feedback. :) Open to ideas for the rewrite.

/cc @empathetic-alligator, @Kealper, @IQAndreas, @jazzychad
Owner

shazow commented Dec 24, 2014

Pinging top contributors, in case you feel like looking around and giving some feedback. :) Open to ideas for the rewrite.

/cc @empathetic-alligator, @Kealper, @IQAndreas, @jazzychad

@shazow shazow added this to the v1.0 milestone Dec 24, 2014

@shazow shazow self-assigned this Dec 24, 2014

@shazow shazow added Help Wanted and removed Help Wanted labels Dec 24, 2014

Show outdated Hide outdated cmd.go

shazow and others added some commits Jan 4, 2015

@shazow
Merge pull request #98 from NickPresta/decrypt-key 
Add support for password-encrypted keys.
d0e442a
@mcroydon
Default port to 2022, updating documentation to match new default. Ad… 
…dresses nice to have in #76.

Also print bind information on startup. An alternative to this approach would be to use info level logging, but the issue makes me think we want it all the time. I altered the README to show use of non-default port 22 which makes the note about root/sudo below still make sense.
492d50d
@shazow
Merge pull request #109 from mcroydon/refactor-port 
Default port to 2022, updating documentation to match new default.
08fde1b
@mcroydon
Updated listening message to use the actual host/port.
98e57c6
@shazow
Merge pull request #112 from mcroydon/refactor-socket 
Updated listening message to use the actual host/port.
03b8ad0
@shazow
Resolve name collision to GuestX, with test.
0c5c7b5
@shazow
Merge branch 'refactor' of github.com:shazow/ssh-chat into refactor
7a39898
@shazow
Use authorized_keys-style public keys rather than fingerprints. 
Tests for whitelisting.
d8d5dea
@shazow
Abstracted sshd.Connection; Op works now.
d5626b7
@shazow
Fixed key storage.
11e92b5
@shazow
/kick and /msg
e626eab
@shazow
Bugfixen.
723313b
@shazow
Mild refactoring towards decoupling channel from host.
587b487
@shazow
Passing /kick test.
50540d2
@shazow
Fix hang condition on kick.
b94911f
@shazow
Connection-level rate limiting.
b99083e
@shazow
Configurable rate limiting for sshd
cc25d17
@shazow
chat.Channel->chat.Room, /ban, /whois, chat.User.Identifier 
- Renamed chat.Channel -> chat.Room
- /ban works, supports IP also
- /whois works
- chat.User now accepts an Identifier interface rather than name
- Tweaked rate limiting
3c4e699
@shazow
chat.Color->chat.Style, highlighting works.
838285b
@shazow
BEL
391a66a
@SamMauldin

This comment has been minimized.

Show comment
Hide comment
@SamMauldin

SamMauldin Jan 18, 2015

Contributor

Why is OP required for whois? Seems like it's public info anyways. Make it a configurable option?
Contributor

SamMauldin commented on host.go in 3c4e699 Jan 18, 2015

Why is OP required for whois? Seems like it's public info anyways. Make it a configurable option?

This comment has been minimized.

Show comment
Hide comment
@shazow

shazow Jan 20, 2015

Owner

Why is OP required for whois?

No good reason, it was changed to public in a later commit. Soon I want to add more metadata for admins (e.g. ip address) than normal users, though.

Make it a configurable option?

Making things configurable increases code complexity, I avoid it whenever possible.
Owner

shazow replied Jan 20, 2015

Why is OP required for whois?

No good reason, it was changed to public in a later commit. Soon I want to add more metadata for admins (e.g. ip address) than normal users, though.

Make it a configurable option?

Making things configurable increases code complexity, I avoid it whenever possible.
@shazow

This comment has been minimized.

Show comment
Hide comment
@shazow

shazow Jan 20, 2015

Owner

Just added a bunch of work. Should be almost at feature parity, would love it if people tried it and let me know how it is. Things I need to add:

  • Name sanitizing
  • Uptime/version

Anything else?
Owner

shazow commented Jan 20, 2015

Just added a bunch of work. Should be almost at feature parity, would love it if people tried it and let me know how it is. Things I need to add:

  • Name sanitizing
  • Uptime/version

Anything else?

@shazow shazow merged commit c4ffd6f into master Jan 20, 2015
1 check was pending

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@shazow

This comment has been minimized.

Show comment
Hide comment
@shazow

shazow Jan 20, 2015

Owner

YAY IT'S MERGED!

Not super battle tested yet, but ready for trial by combat.
Owner

shazow commented Jan 20, 2015

YAY IT'S MERGED!

Not super battle tested yet, but ready for trial by combat.

@shazow shazow deleted the refactor branch Jan 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment