Fix coverage for Windows. #166

Merged
merged 1 commit into from Mar 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

schlamar commented Mar 25, 2013

No description provided.

Owner

shazow commented Mar 25, 2013

Hmm, at this point every line of that function is uncovered. I would prefer to revert this change for style consistency and just add the coverage exception comment to the def ... line. What do you think?

@shazow shazow commented on an outdated diff Mar 25, 2013

urllib3/util.py
return False
- if not poll: # Platform-specific
- if not select: # Platform-specific: AppEngine
@shazow

shazow Mar 25, 2013

Owner

I rather keep the original annotations which are informative (e.g. the ones that mention AppEngine or specific platforms). Makes it easier to keep track what's for what.

Contributor

schlamar commented Mar 25, 2013

Updated.

@shazow shazow added a commit that referenced this pull request Mar 25, 2013

@shazow shazow Merge pull request #166 from schlamar/fix-coverage
Fix coverage for Windows.
2aa3e4a

@shazow shazow merged commit 2aa3e4a into shazow:master Mar 25, 2013

1 check passed

default The Travis build passed
Details
Owner

shazow commented Mar 25, 2013

Thank you!

schlamar deleted the unknown repository branch Mar 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment