Content-Type header values should be native strings #168

merged 2 commits into from Apr 2, 2013


None yet

2 participants

Lukasa commented Apr 2, 2013

In response to the discussion kennethreitz/requests#1252, this PR would ensure that any calculated header key is returned as a native string.

Obviously, feel free to code review this. Let me know if you want me to go about this in a different way, or anything. =)

Lukasa added some commits Apr 2, 2013
@Lukasa Lukasa Tests for bad Content-Type type.
Content-Type should be returned as a native string, not a bytestring.
This commit ensures that all current tests that exercise the encoding
fail on Python 3, where native strings aren't bytestrings.
@Lukasa Lukasa Return native strings for header-values. d75a807
@shazow shazow merged commit 82cee12 into shazow:master Apr 2, 2013

1 check passed

default The Travis build passed
shazow commented Apr 2, 2013

Thank you!

Lukasa commented Apr 2, 2013

Happy to help. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment