Default to XDG_CONFIG_HOME/mume instead of ~/.mume for configPath
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To preserve compatibility, it only does this if the old location (`~/.mume`) does not exist
hyperupcall
changed the title
XDG_CONFIG_HOMEXDG_CONFIG_HOME/mume instead of ~/.mume for configPath
Owner
|
Would this work on Windows? Thanks! |
Since the XDG Base Directory Specification shouldn't be followed on windows, we make sure to use the old format if the underlying platform is deteted to be windows
Contributor
Author
|
Oh right! The XDG Base Directory Specification shouldn't be followed on Windows. I'll fix that really quickly |
Contributor
Author
|
Cool beans - so now it is now correct for windows. I'll add that this also enables the behavior for macOS and other Unix platforms. In my opinion, it's okay to check for (and use) |
shd101wyy
approved these changes
Aug 5, 2021
Owner
shd101wyy
left a comment
shd101wyy
left a comment
There was a problem hiding this comment.
Looks really good to me. Thanks a lot :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #173 made it possible to easily change the
configPathfor mume. This changes the default to~/.config/mumeinstead of~/.mume(but only if~/.mumedoes not exist!) to remove clutter in the home directory.This would close #66