Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet import Error #32

Closed
signo opened this Issue May 19, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@signo
Copy link

signo commented May 19, 2015

I just created an export file from the site i have my snippets to import them to a new site, when i click the "Upload file and import button" all i get is a new browser page with the url http://array/, both sites have wp 4.2.2 and the latest code-snippets version installed. I deactivated all the plugins but code-snippet before the import to discard any conflict. I tried importing a snippet file that i exported with the previous version and still the same problem.

@sheabunge

This comment has been minimized.

Copy link
Owner

sheabunge commented May 19, 2015

Thanks very much for reporting this bug. It looks like it was accidentally added in ab191c7. The fix should be included in version 2.3.0, which will hopefully be coming out very soon.

However, to me it appears that this bug only takes place after importing, when the results are displayed to you. So the snippets should still have been imported regardless of this error, right?

@signo

This comment has been minimized.

Copy link
Author

signo commented May 19, 2015

Yes, it did import the snippets with no problem. One observation though, i did import the file several times when testing, this of course made several repeated copies of the snippets, i know there is no way to make an unique id for snippets, but maybe you could check the snippet name to avoid repetitions, or better yet you could place a radio button in the import screen with options to "replace existing snippets" or ignore "existing snippets" this way you can give the user some control on that respect.

@sheabunge

This comment has been minimized.

Copy link
Owner

sheabunge commented May 20, 2015

@signo good idea, I've created a new issue with your suggestion so it can be implemented into a future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.