Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Allow to manually update asset GPS location #914

Closed
DonKoko opened this issue Apr 16, 2024 · 5 comments · Fixed by #922
Closed

[Feature request]: Allow to manually update asset GPS location #914

DonKoko opened this issue Apr 16, 2024 · 5 comments · Fixed by #922
Assignees
Labels
Priority: High Issues that are with very high priority User requested feature

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Apr 16, 2024

Contact Details

No response

Is your feature request related to a problem? Please describe?

Currently, when you scan a QR code the app asks you for location permissions and updates the gps coordinates of where the scan has happened.
Because of so many different devices and browsers, the location functionality is flaky and is sometimes blocked, especially on android.

Describe the solution you'd like

After scanning, add an option in the menu to update the GPS coordinates of the asset. The manual action will make sure that it works every time the user has the intention.

We have to also adjust a bit the terms we use. Our users are very confused between "Location" (as in the model) and "Scan location" as in the gps coordinates of the last scan.

We have to re-think these terms and improve them

Describe alternatives you've considered

No response

Additional context

No response

@DonKoko DonKoko added User requested feature Priority: High Issues that are with very high priority labels Apr 16, 2024
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 16, 2024

@jurrejansen we need some small designs and thinking about updating the terms. Can you please take a look and give a suggestion as this is very high prio because the current version is not working consistently enough.

@jurrejansen
Copy link

@DonKoko something like this?

Screenshot 2024-04-16 at 11 46 45

@jurrejansen jurrejansen assigned DonKoko and unassigned jurrejansen Apr 16, 2024
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 16, 2024

@jurrejansen I like it. I would rather have the copy be "Update GEO position" so we stay away from the word location to avoid confusion. @carlosvirreira what do you think?

@carlosvirreira
Copy link
Contributor

I'd say lets update the copy to "Update GPS coordinates"

@carlosvirreira
Copy link
Contributor

Updated design @DonKoko

Inspect _ Actions v2

@DonKoko DonKoko linked a pull request Apr 23, 2024 that will close this issue
@DonKoko DonKoko pinned this issue Apr 23, 2024
@DonKoko DonKoko unpinned this issue Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Issues that are with very high priority User requested feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants