New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclamation mark does not work with french keyboard layout #81

Closed
KLuka opened this Issue Mar 3, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@KLuka
Member

KLuka commented Mar 3, 2015

From lot...@gmail.com on August 03, 2010 18:19:13

What steps will reproduce the problem? 1. Configure a French keyboard (AZERTY) layout in the OS
2. Type "!" in a ShellInABox console (key next to the right shift key) What is the expected output? What do you see instead? Exclamation mark should appear on the command line. Nothing actually appears.
Quite annoying for VI... What version of the product are you using? On what operating system? Version 2.10, or demo on ShellInABox homepage Please provide any additional information below. The exclamation mark (keycode 223) seems to be treated as a control character, which it is not.
The problem does not appear with a QWERTY keyboard layout because "!" is the secondary symbol on the "1" key, which is recognized correctly.

Original issue: http://code.google.com/p/shellinabox/issues/detail?id=81

@KLuka

This comment has been minimized.

Show comment
Hide comment
@KLuka

KLuka Mar 3, 2015

Member

From lot...@gmail.com on August 04, 2010 02:33:09

Quick fix : accept keycode 223 as a normal key.

Attachment: keycode223.diff

Member

KLuka commented Mar 3, 2015

From lot...@gmail.com on August 04, 2010 02:33:09

Quick fix : accept keycode 223 as a normal key.

Attachment: keycode223.diff

@KLuka

This comment has been minimized.

Show comment
Hide comment
@KLuka

KLuka Mar 3, 2015

Member

From lot...@gmail.com on August 19, 2010 03:04:01

Do you need anything else to apply the fix ?

Member

KLuka commented Mar 3, 2015

From lot...@gmail.com on August 19, 2010 03:04:01

Do you need anything else to apply the fix ?

@KLuka

This comment has been minimized.

Show comment
Hide comment
@KLuka

KLuka Mar 3, 2015

Member

From zod...@gmail.com on August 19, 2010 12:13:42

Thank you very much for a) your excellent analysis, b) writing an actual patch, and c) pinging me when I didn't reply in time.

I was too busy with other work and never even noticed that you had provided a patch. As fixing keyboard layout problems is difficult without having access to a French keyboard and without understanding how the keyboard is supposed to behave, I often treat these bugs as lower priority.

But none of that excuses me ignoring your patch. That's actually extremely helpful and is the best type of bugreport that I can hope for!

Status: Fixed

Member

KLuka commented Mar 3, 2015

From zod...@gmail.com on August 19, 2010 12:13:42

Thank you very much for a) your excellent analysis, b) writing an actual patch, and c) pinging me when I didn't reply in time.

I was too busy with other work and never even noticed that you had provided a patch. As fixing keyboard layout problems is difficult without having access to a French keyboard and without understanding how the keyboard is supposed to behave, I often treat these bugs as lower priority.

But none of that excuses me ignoring your patch. That's actually extremely helpful and is the best type of bugreport that I can hope for!

Status: Fixed

@KLuka

This comment has been minimized.

Show comment
Hide comment
@KLuka

KLuka Mar 3, 2015

Member

From joachim...@gmail.com on December 19, 2012 03:39:37

Thanks a lot for this patch.

For any reason i had no problem with my home keyboard when i installed and tested shellinabox and then get stuck with "login failed" error with a different keyboard because i have a ! (exclamation character) in my password.
Both keyboard are "azerty"...

Hopefully the patch is to be applied on the js file so i could access it client-side first to be able to login, and then i changed it server side to correct it definitely.

Thanks again and maybe this 2010 patch should be applyed on to the ubuntu binary i downloaded yesterday.

Member

KLuka commented Mar 3, 2015

From joachim...@gmail.com on December 19, 2012 03:39:37

Thanks a lot for this patch.

For any reason i had no problem with my home keyboard when i installed and tested shellinabox and then get stuck with "login failed" error with a different keyboard because i have a ! (exclamation character) in my password.
Both keyboard are "azerty"...

Hopefully the patch is to be applied on the js file so i could access it client-side first to be able to login, and then i changed it server side to correct it definitely.

Thanks again and maybe this 2010 patch should be applyed on to the ubuntu binary i downloaded yesterday.

@KLuka KLuka closed this Mar 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment