Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs very slow #440

Closed
narehart opened this issue May 10, 2016 · 2 comments
Closed

phpcs very slow #440

narehart opened this issue May 10, 2016 · 2 comments
Labels
exec perf

Comments

@narehart
Copy link

@narehart narehart commented May 10, 2016

Node version: 5.6.0

ShellJS version (the most recent version/Github branch you see the bug on): 0.6.0

Operating system: OS X 10.11.4

Description of the bug: Running phpcs through shelljs is incredibly slow. Directly through shell, running phpcs on an empty php file takes 16ms. Running through shelljs the same command takes 59s.

Example ShellJS command to reproduce the error:

var shell = require('shelljs');

shell.exec('phpcs --report=json --standard=PSR2 -n ./test/test.php');
console.log(shell.stdout);
@synaptiko
Copy link

@synaptiko synaptiko commented Aug 3, 2017

@edmcmanwich If you want you can try to use my branch for the test. It should improve the perf.

@nfischer nfischer added the exec label Jul 12, 2018
@nfischer
Copy link
Member

@nfischer nfischer commented Jul 12, 2018

This will basically be fixed in #866. Merging into #495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exec perf
Projects
None yet
Development

No branches or pull requests

3 participants