You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
ShellJS version (the most recent version/Github branch you see the bug on):
Description of the bug:
Due to Node.js default behavior about encoding, all standard output will be transformed hard to utf-8. However, the default encoding of CMD is based on default lang of Windows, which means once you send command to non-utf8 terminal you will get non-utf8 output with utf-8 buffer string. That would probably irreversible, at least in my case in Chinese GB2312 (or Windows-936) encoding. Using iconv cannot revert the output again.
Would this be better suited as a bug filed against Node itself or shelljs? If it's better to fix it here, that sounds good to me.
I'm still unsure if this is our bug or Node's, and I don't know how to further investigate. I'm going to close this, but please ping this thread if this is still an issue and anyone has ideas for how to move this bug forward.