Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec() should support node v10 (maxbuffer change) #915

Closed
nfischer opened this issue Dec 2, 2018 · 0 comments
Closed

exec() should support node v10 (maxbuffer change) #915

nfischer opened this issue Dec 2, 2018 · 0 comments

Comments

@nfischer
Copy link
Member

@nfischer nfischer commented Dec 2, 2018

See #856 (comment)

This involves rewriting a test, but also fixing shell.exec() to expect the RangeError.

nfischer added a commit that referenced this issue Dec 3, 2018
This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915
nfischer added a commit that referenced this issue Dec 3, 2018
This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

This also supports the change in Node v10, which emits this as a
RangeError instead of a regular Error.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915
@nfischer nfischer closed this in #919 Dec 3, 2018
nfischer added a commit that referenced this issue Dec 3, 2018
* fix(exec): consistent error message for maxBuffer

This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

This also supports the change in Node v10, which emits this as a
RangeError instead of a regular Error.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915

* Remove debugging log, ignore uncovered lines
@nfischer nfischer mentioned this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant