Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): lockdown file permissions #1060

Merged
merged 1 commit into from Jan 7, 2022
Merged

fix(exec): lockdown file permissions #1060

merged 1 commit into from Jan 7, 2022

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Jan 7, 2022

This locks down file permissions used by the internal implementation of
shell.exec().

Issue #1058
Tested manually using the documented scenarios

This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #1060 (118539f) into master (d0a4516) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   97.14%   97.15%           
=======================================
  Files          35       35           
  Lines        1332     1335    +3     
=======================================
+ Hits         1294     1297    +3     
  Misses         38       38           
Impacted Files Coverage Δ
src/exec.js 95.06% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a4516...118539f. Read the comment docs.

@nfischer nfischer merged commit 003a39d into master Jan 7, 2022
42 checks passed
@nfischer nfischer deleted the exec-lockdown-perms branch Jan 7, 2022
nfischer added a commit that referenced this issue Jan 7, 2022
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@nfischer nfischer linked an issue that may be closed by this pull request Jan 7, 2022
@nfischer nfischer added this to the v0.8.5 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants