Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cp from readonly source #870

Merged
merged 3 commits into from Jul 10, 2018
Merged

Fix cp from readonly source #870

merged 3 commits into from Jul 10, 2018

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Jul 4, 2018

This is a redo of PR #555.

This rebases, cleans up a test, and fixes a bug (the original PR uses fs.chown() instead of fs.chownSync()).

Fixes #98

@nfischer nfischer added the fix label Jul 4, 2018
@nfischer nfischer self-assigned this Jul 4, 2018
@nfischer nfischer requested a review from freitagbr Jul 4, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 4, 2018

Codecov Report

Merging #870 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #870      +/-   ##
=========================================
+ Coverage    95.8%   95.8%   +<.01%     
=========================================
  Files          34      34              
  Lines        1262    1263       +1     
=========================================
+ Hits         1209    1210       +1     
  Misses         53      53
Impacted Files Coverage Δ
src/cp.js 86.4% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd437e...bedc538. Read the comment docs.

@nfischer
Copy link
Member Author

@nfischer nfischer commented Jul 4, 2018

@freitagbr ready for review. Please review commit-by-commit (My commits are separate from the original PR's commits). The original PR essentially had my LGTM.

Copy link
Contributor

@freitagbr freitagbr left a comment

LGTM

@nfischer nfischer merged commit 131b88f into master Jul 10, 2018
4 checks passed
@nfischer nfischer added this to the v0.8.x milestone Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants