Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent exec #892

Merged
merged 2 commits into from Oct 27, 2018
Merged

Fix silent exec #892

merged 2 commits into from Oct 27, 2018

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Oct 10, 2018

Based on #861

Fixes #851
Fixes #891

@nfischer
Copy link
Member Author

@nfischer nfischer commented Oct 10, 2018

CI is busted right now. I think an npm update is modifying package-lock.json. For some reason it only repros on node v8. Same thing blocks #889 (CC @joshi-sh).

@nfischer nfischer self-assigned this Oct 24, 2018
@nfischer nfischer merged commit 2b3b781 into master Oct 27, 2018
2 of 4 checks passed
@nfischer nfischer deleted the fix-silent-exec branch Oct 27, 2018
@nfischer
Copy link
Member Author

@nfischer nfischer commented Jan 5, 2019

This was released in v0.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant