Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): add ci-or-install script #896

Merged
merged 4 commits into from Oct 27, 2018
Merged

chore(npm): add ci-or-install script #896

merged 4 commits into from Oct 27, 2018

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Oct 25, 2018

This adds a script which checks the npm version and runs either npm ci
or npm install based on support. This is primarily to work around an
issue where npm install modifies package-lock.json for newer npm
versions.

A side benefit is that npm ci is slightly faster than npm install.

Fixes #893

This adds a script which checks the npm version and runs either `npm ci`
or `npm install` based on support. This is primarily to work around an
issue where `npm install` modifies `package-lock.json` for newer npm
versions.

A side benefit is that `npm ci` is slightly faster than `npm install`.

Fixes #893
@nfischer nfischer added chore fix high priority labels Oct 25, 2018
@nfischer nfischer self-assigned this Oct 25, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 27, 2018

Codecov Report

Merging #896 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          34       34           
  Lines        1266     1266           
=======================================
  Hits         1213     1213           
  Misses         53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e861db...bb45ff5. Read the comment docs.

@nfischer nfischer merged commit 37acb86 into master Oct 27, 2018
4 checks passed
@nfischer nfischer deleted the chore-use-npm-ci branch Oct 27, 2018
nfischer added a commit that referenced this issue Nov 29, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile
caused headaches, since `npm install` would modify the lockfile.

Unfortunately, `ci-or-install` (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893
nfischer added a commit that referenced this issue Nov 29, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile
caused headaches, since `npm install` would modify the lockfile.

Unfortunately, `ci-or-install` (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893
nfischer added a commit that referenced this issue Nov 30, 2018
This removes our lockfile and our `ci-or-install` script. The lockfile
caused headaches, since `npm install` would modify the lockfile.

Unfortunately, `ci-or-install` (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore fix high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants