Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change language to node_js and remove obsolete scripts #910

Merged
merged 1 commit into from Nov 29, 2018
Merged

ci: change language to node_js and remove obsolete scripts #910

merged 1 commit into from Nov 29, 2018

Conversation

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Nov 29, 2018

We can safely use node_js on all three supported platforms on Travis CI and remove the obsolete scripts.

See #908 (comment)

@codecov-io
Copy link

@codecov-io codecov-io commented Nov 29, 2018

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          34       34           
  Lines        1271     1271           
=======================================
  Hits         1237     1237           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d8bbf...ad8991f. Read the comment docs.

@nfischer nfischer merged commit 26d6e0e into shelljs:master Nov 29, 2018
2 checks passed
@nfischer nfischer added the chore label Nov 29, 2018
@DanielRuf DanielRuf deleted the ci/language-nodejs branch Nov 29, 2018
@nfischer
Copy link
Member

@nfischer nfischer commented Nov 29, 2018

@DanielRuf I'll eventually do the same for shelljs/shx (but feel free to send a PR if you get to it first).

nfischer added a commit to shelljs/shx that referenced this issue Nov 30, 2018
See also: shelljs/shelljs#910

This switches Travis to use the node_js language. We originally used the
C++ language because OS X didn't properly support the node_js language
(so we had to do all setup manually). This is no longer the case.
nfischer added a commit to shelljs/shx that referenced this issue Dec 2, 2018
See also: shelljs/shelljs#910

This switches Travis to use the node_js language. We originally used the
C++ language because OS X didn't properly support the node_js language
(so we had to do all setup manually). This is no longer the case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants