Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): remove lockfile #911

Merged
merged 1 commit into from Nov 30, 2018
Merged

chore(npm): remove lockfile #911

merged 1 commit into from Nov 30, 2018

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Nov 29, 2018

This removes our lockfile and our ci-or-install script. The lockfile
caused headaches, since npm install would modify the lockfile.

Unfortunately, ci-or-install (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893

This removes our lockfile and our `ci-or-install` script. The lockfile
caused headaches, since `npm install` would modify the lockfile.

Unfortunately, `ci-or-install` (added in #896) didn't work reliably on
appveyor, so removing the lockfile seems easier. We remove the script
since it's now obsolete.

Fixes #893
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 30, 2018

Codecov Report

Merging #911 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          34       34           
  Lines        1271     1271           
=======================================
  Hits         1237     1237           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d6e0e...f3ec88e. Read the comment docs.

@nfischer nfischer merged commit 87c1ff7 into master Nov 30, 2018
4 checks passed
@nfischer nfischer deleted the chore-no-lockfile branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants