Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): no coverage by default #920

Merged
merged 1 commit into from Dec 3, 2018
Merged

chore(test): no coverage by default #920

merged 1 commit into from Dec 3, 2018

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Dec 3, 2018

NYC takes forever on my local machine, and I generally prefer to look at
coverage reports on the website anyway.

This changes npm test to run without coverage, and changes our CI to
run npm run test-with-coverage instead.

NYC takes forever on my local machine, and I generally prefer to look at
coverage reports on the website anyway.

This changes `npm test` to run without coverage, and changes our CI to
run `npm run test-with-coverage` instead.
@nfischer nfischer added the chore label Dec 3, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 3, 2018

Codecov Report

Merging #920 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          34       34           
  Lines        1271     1271           
=======================================
  Hits         1237     1237           
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb72ed...51e83e6. Read the comment docs.

@nfischer nfischer merged commit 5cab915 into master Dec 3, 2018
4 checks passed
@nfischer nfischer deleted the chore-test-no-coverage branch Dec 3, 2018
nfischer added a commit that referenced this issue Jan 4, 2019
This adds initial support for long options. This integration tests them
with `shell.touch()` and unit tests them in `test/common.js`.

This also refactors some of the common internals:

 * Creates a new CommandError type to replace the `'earlyExit'` hack
 * Clearer Error types for `parseOptions()` exceptions
 * Removes side effects from a test which modifies `common.config`
 * Fixes appveyor and travis config to run lint (regressed in #920)

Issue #924
Test: touch.js, common.js
nfischer added a commit that referenced this issue Jan 4, 2019
This adds initial support for long options. This integration tests them
with `shell.touch()` and unit tests them in `test/common.js`. This
documents the new syntax.

This also refactors some of the common internals:

 * Creates a new CommandError type to replace the `'earlyExit'` hack
 * Clearer Error types for `parseOptions()` exceptions
 * Removes side effects from a test which modifies `common.config`
 * Fixes appveyor and travis config to run lint (regressed in #920)

Issue #924
Test: touch.js, common.js
nfischer added a commit that referenced this issue Jan 5, 2019
* feat(options): initial support for long options

This adds initial support for long options. This integration tests them
with `shell.touch()` and unit tests them in `test/common.js`. This
documents the new syntax.

This also refactors some of the common internals:

 * Creates a new CommandError type to replace the `'earlyExit'` hack
 * Clearer Error types for `parseOptions()` exceptions
 * Removes side effects from a test which modifies `common.config`
 * Fixes appveyor and travis config to run lint (regressed in #920)

Issue #924
Test: touch.js, common.js

* small refactor for errorOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants